This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Sunday, February 06, 2011 18:06:51 H.J. Lu wrote: > On Sun, Feb 6, 2011 at 2:54 PM, Mike Frysinger <vapier@gentoo.org> wrote: > > On Sunday, February 06, 2011 17:46:45 H.J. Lu wrote: > >> On Sun, Feb 6, 2011 at 10:28 AM, Mike Frysinger <vapier@gentoo.org> wrote: > >> > 2011-02-06 Mike Frysinger <vapier@gentoo.org> > >> > > >> > * sysdeps/x86_64/multiarch/memcpy-ssse3.S: Delete SHARED ifdef > >> > check around MEMCPY_CHK symbol. > >> > * sysdeps/x86_64/multiarch/memcpy-ssse3-back.S: Likewise. > >> > >> I don't think it is correct. Please try this. > > > > i dont think either are correct now that you posted this. the whole file > > is protected by: > > #if !defined NOT_IN_libc \ > > && (defined SHARED \ > > || defined USE_AS_MEMMOVE \ > > || !defined USE_MULTIARCH) > > > > so there isnt much point in checking any of these inside of that. just > > delete the whole #if protection from the MEMCPY_CHK symbol. > > We don't want to define memcpy_chk in libc.a twice, how is that relevant ? if the code does: #if !defined(A) && defined(B) then in the middle does: #if defined(B) the 2nd check is pointless. that's all your updated patch does. -mike
Attachment:
signature.asc
Description: This is a digitally signed message part.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |