This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH,HURD] Fix sysdep.h and thread_state.h inclusion protection

From: Samuel Thibault <samuel dot thibault at ens-lyon dot org>
To: Roland McGrath <roland at redhat dot com>
Cc: libc-alpha at sources dot redhat dot com
Date: Wed, 16 Feb 2011 23:50:25 +0100
Subject: Re: [PATCH,HURD] Fix sysdep.h and thread_state.h inclusion protection
References: <20110216223433.GG5345@const.famille.thibault.fr> <20110216224231.1BC431802A2@magilla.sf.frob.com>

Roland McGrath, le Wed 16 Feb 2011 14:42:31 -0800, a écrit :
> These are libc-internal headers.  Why do they get included more than once?

./sysdeps/i386/i686/multiarch/memcmp.S includes sysdep.h,
redefines the ENTRY macro, and then ../memcmp.s, which is
./sysdeps/i386/i686/memcmp.S, which includes sysdep.h again, which
redefines the ENTRY macro again to something else, making the first
memcmp.S definition moot. There is no such issue on Linux since it has
inclusion protection.

Samuel

References:
- [PATCH,HURD] Fix sysdep.h and thread_state.h inclusion protection
  - From: Samuel Thibault
- Re: [PATCH,HURD] Fix sysdep.h and thread_state.h inclusion protection
  - From: Roland McGrath

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]