This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] memset: fix define usage for shared libs

From: Mike Frysinger <vapier at gentoo dot org>
To: Ulrich Drepper <drepper at gmail dot com>
Cc: libc-alpha at sourceware dot org
Date: Sun, 17 Apr 2011 22:41:33 -0400
Subject: Re: [PATCH] memset: fix define usage for shared libs
References: <1298399284-1537-1-git-send-email-vapier@gentoo.org> <BANLkTinWPGVd9tJsmaayy80_oS+FdaYmjQ@mail.gmail.com>

On Sunday, April 17, 2011 21:12:00 Ulrich Drepper wrote:
> On Tue, Feb 22, 2011 at 13:28, Mike Frysinger <vapier@gentoo.org> wrote:
> > The proper define to check "am I in a shared lib" is "SHARED", not "PIC".
> > The two new memset_chk functions incorrectly depend on "PIC".
> 
> What is failing without this patch?

building the static libs as PIC

> I should just discard any patch which comes without justification.

i already gave you justification -- PIC is not the right symbol to check for 
code going shared libraries.  that is entirely why SHARED was added.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

Follow-Ups:
- Re: [PATCH] memset: fix define usage for shared libs
  - From: Ulrich Drepper

References:
- Re: [PATCH] memset: fix define usage for shared libs
  - From: Ulrich Drepper

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]