This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 5/10] Tilera (and Linux asm-generic) support for glibc
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Chris Metcalf <cmetcalf at tilera dot com>
- Cc: libc-alpha at sourceware dot org, Arnd Bergmann <arnd at arndb dot de>, Linas Vepstas <linas at codeaurora dot org>, Guan Xuetao <gxt at mprc dot pku dot edu dot cn>, Jonas Bonn <jonas at southpole dot se>, Chen Liqin <liqin dot chen at gmail dot com>
- Date: Fri, 11 Nov 2011 09:59:15 -0800 (PST)
- Subject: Re: [PATCH v2 5/10] Tilera (and Linux asm-generic) support for glibc
- References: <201111100054.pAA0sf6u025585@farm-0002.internal.tilera.com><201111100056.pAA0uFcX025800@farm-0002.internal.tilera.com>
> diff --git a/include/fenv.h b/include/fenv.h
> index 3605f81..c061eb9 100644
> --- a/include/fenv.h
> +++ b/include/fenv.h
> @@ -20,4 +20,10 @@ libm_hidden_proto (feholdexcept)
> libm_hidden_proto (feupdateenv)
> libm_hidden_proto (fetestexcept)
>
> +/* Allow coding feraiseexcept() without guarding the call with an
> + ifdef of the argument, to suport platforms without FP exceptions. */
There's a typo in this comment.
> +#if FE_ALL_EXCEPT == 0
> +# define feraiseexcept(e) ({ 1; })
> +#endif
This is just generically bad macro practice: it fails to evaluate its argument.
Those nits aside, I need some more explanation of what this is for.
Thanks,
Roland