This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use __unused0 instead of __unused for user visible struct members
On Mon, Jan 9, 2012 at 4:22 PM, Ulrich Drepper <drepper@gmail.com> wrote:
>> What technical or non-technical reasons are there for
>> *not* making the change?
>
> Every idiot will come and say their code uses something and header
> must be changed. ?If anything, *that* is the slippery slope. ?It must
> be the responsibility of the user-level code developers to not make
> mistakes like that.
Is the key reason for not making the change because there may be
requests from others to make similar changes? That doesn't seem like
sound technical decision making. Each request would surely be
evaluated on its own merit.
It is certainly the responsibility of user-level code developers to
fix their mistakes, but in this case it's an established practice on
another system. The requested change does little to alter the
maintainability of glibc, but allows more code to be ported to a
platform that I use every day.
Yes, the slope is slippery, but this seems to be a mechanical change
that is not yet near the slippery part, and benefits all users of
glibc?
Pro:
* Enables porting more code to run on platforms that use glibc.
* Easy to verify patch with little maintenance impact.
Cons:
* Possible future requests to make similar changes need to be evaluated.
This seems like a win to me.
Cheers,
Carlos.