This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: pthread_attr build regressions
On Mon, Feb 27, 2012 at 3:48 PM, David Miller <davem@davemloft.net> wrote:
> From: "Carlos O'Donell" <carlos@systemhalted.org>
> Date: Mon, 27 Feb 2012 15:30:50 -0500
>
>> I agree. This kind of work could have been done on a short-lived
>> feature branch. Followed by a request for testing.
>
> In the mean time is it OK if I check in this obvious fix (with
> appropriate ChangeLog entry) so that developers can get work done?
Yes, please do. These are trivial and obvious error fixes.
I had asked Ulrich to do this himself here:
http://sourceware.org/ml/libc-alpha/2012-02/msg00659.html
However, he has not gotten to it yet.
On i386 there are more build fixes than this required though so beware.
e.g.
diff --git a/sysdeps/posix/spawni.c b/sysdeps/posix/spawni.c
index 11a74b5..6583fd4 100644
--- a/sysdeps/posix/spawni.c
+++ b/sysdeps/posix/spawni.c
@@ -22,6 +22,7 @@
#include <spawn.h>
#include <stdlib.h>
#include <string.h>
+#include <signal.h>
#include <unistd.h>
#include <sys/resource.h>
#include "spawn_int.h"
diff --git a/sysdeps/pthread/aio_cancel.c b/sysdeps/pthread/aio_cancel.c
index b160f55..0ec1592 100644
--- a/sysdeps/pthread/aio_cancel.c
+++ b/sysdeps/pthread/aio_cancel.c
@@ -31,6 +31,7 @@
#endif
#include <assert.h>
+#include <fcntl.h>
#include <errno.h>
#include <aio_misc.h>
diff --git a/sysdeps/pthread/aio_fsync.c b/sysdeps/pthread/aio_fsync.c
index 1fc39b9..f72c4da 100644
--- a/sysdeps/pthread/aio_fsync.c
+++ b/sysdeps/pthread/aio_fsync.c
@@ -27,6 +27,8 @@
#include <aio.h>
/* And undo the hack. */
#undef aio_fsync64
+
+#include <fcntl.h>
#include <errno.h>
#include <aio_misc.h>
All caused by the shuffling of headers and the breaking of
implicit include paths.
All of these changes fall under the "obvious" banner of
including the header files that you need for the the type
and macros that you use.
Therefore commits for all of these fixes are welcome.
Please post them for review and I'll ACK them.
I'd fix it right now but I'm stuck doing other things.
Cheers,
Carlos.