This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/8] x86_64: Convert __ieee754_sqrt{,f,l} from macrosto inlines.
On 03/07/12 16:07, Roland McGrath wrote:
> I think you really should use __attribute__ ((always_inline)) in some form,
> rather than just expecting that the fact that today's compiler inlines
> means that future compilers (and other configurations, etc.) always will.
> The __always_inline macro is indeed convenient for this.
>
> We have __extern_always_inline used for public functions but that's not
> ideal because it uses artificial too and thus intentionally degrades the
> specificity of error messages (and debug info?). It's really only meant
> for _FORTIFY_SOURCE wrappers.
I'll use __always_inline consistently, in the "extern __always_inline" form
for those functions that require it.
Given that patches 2-4 are exclusively de-macro-ization, can I assume that
they would be approved given that change?
r~