This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix sinf, cosf, sincosf,tanf on x86 (BZ#13852)


On Thursday, March 15, 2012 17:49:44 Joseph S. Myers wrote:
> On Thu, 15 Mar 2012, Andreas Jaeger wrote:
> > This update fixes sinf, cosf, tanf and sincosf to not use the x87 fpu
> > and thus work with large inputs as well. It adds a few new ULPS with
> > values 1 or 2.
> 
> Looks good to me.  Hopefully tan (double) (x86) should also be
> straightforward to fix using the _53bit macros.

Would be fine but I'm not volunteering.

> > +#ifndef TEST_LDOUBLE
> > +  /* Enable for long double once x86 and x86-64 implementations are
> > fixed.  */ +  TEST_f_f (cos, 0x1p65,
> > 0.998886220660580136106421721793L); +  TEST_f_f (cos, -0x1p65,
> > 0.998886220660580136106421721793L);
> 
> Note that 30 decimal places won't be enough for ldbl-128 or ldbl-128ibm
> (you need at least 35 places, I generally use 40).  Though I can always
> fix constants with too few decimal places when enabling tests for long
> double along with adding ldbl-96 implementations.

Ok, let me add 40 digits now for all these and commit,

Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]