This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix atan2 spurious exceptions (bug 11451)


On 03/19/2012 06:45 PM, Joseph S. Myers wrote:
Bug 11451 reports atan2 raising spurious overflow exceptions for large
input on x86_64.  (It also raises spurious invalid exceptions for the
same input, not mentioned in that bug report.)  The code already
scales the inputs if very small, and already has handling for the case
where the inputs are very different in magnitude; I propose this patch
adding scaling for large inputs.

Unfortunately libm-test.inc does not check the overflow exception, just the values. So, the testsuite does not really cover the bug you're fixing and there's no good place to add it. What do you think of creating a new test case that tests the overflow and underflow case?


Tested x86_64 and x86; no ulps changes needed.

2012-03-19 Joseph Myers<joseph@codesourcery.com>

	[BZ #11451]
	* sysdeps/ieee754/dbl-64/e_atan2.c (__ieee754_atan2): Scale large
	x and y.
	* math/libm-test.inc (atan2_test): Add another test.


this is fine, thanks,

Andreas
--
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]