This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: vfprintf typing problem


On Mon, Apr 2, 2012 at 7:09 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> David Miller <davem@davemloft.net> writes:
>
>> + ? ?if (0 <= retval)
> ? ? ? ? ? retval >= 0

Why do you make this suggestion? Is this just so that the code follows
the existing style?

Placing the constant first has the benefit that it avoids accidental
assignment, but does require practice to read it easily while parsing
code.

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]