This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Append system library paths to environment for testprograms


On Mon, 2 Apr 2012 09:00:38 -0400
"Carlos O'Donell" <carlos@systemhalted.org> wrote:
> These failures are because you used --prefix but didn't provide a
> correctly built sysroot in --prefix.
> 
> I'm strongly against querying the compiler and adding whatever paths
> it used to our library search list. Why? It complicates testing by
> providing poor separation of the test framework from the natively
> installed libraries. This becomes even more important when
> cross-compiling and cross-testing.

I don't think the requirement of having a sysroot within whatever
prefix glibc is going to be installed is feasible, more so because it
is necessary *just* for running the testsuite.

There is no real difference (on the 'separation from native libraries'
front) between appending library search paths from the compiler to test
case search paths, and working with a prefix that is a pre-built sysroot
because the search order is what matters in the end and both cases
have the same search order. The only things that could go wrong are:

1) The dynamic linker has a bug due to which it mucks up the search
order
2) Some targets were not built and libraries from the native system
were picked up instead

Both approaches are vulnerable to the above failures. In fact, I don't
think there is a way to separate the test framework from the native
system beyond a point that we already do unless you either decide to
manually copy over dependencies using some magic method (which I think
will eventually involve getting search paths used during build) or
statically link anything that is external (which will again involve
getting search paths used during build).


Regards,
Siddhesh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]