This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add --print-dirs option for ldconfig


On Mon, Apr 02, 2012 at 09:45:41AM -0700, Roland McGrath wrote:
> > --- a/ChangeLog
> > +++ b/ChangeLog
> 
> The ChangeLog portion is not included in the diff, but the fragment
> separately as simple text in your message.

I see. I'd noticed Dave had done that and it does seem better to not
have the ChangeLog be part of the diff since it's easy to conflict. Is
there a tool you guys use to generate the ChangeLog entry for the
patch text and/or merge the entry into the actual ChangeLog when
applying patches?

> > @@ -1,3 +1,9 @@
> > +2012-03-28  Dan Nicholson  <dbn.lists@gmail.com>
> > +
> > +	* elf/ldconfig.c (opt_print_dirs): New option enabled with -P or
> > +	--print-search-dirs.
> > +	(main): Use it to print the linker search path.
> 
> 	* elf/ldconfig.c (opt_print_dirs): New variable.
> 	(options, parse_opt): Add --print-search-dirs/-P to set it.
> 	(main): just When set, print the linker search path.
> 
> But you might as well name the variable opt_print_search_dirs for
> consistency with the option name.

Makes sense. See attached update.

--
Dan

Attachment: print-dirs-v3.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]