This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix a regression bug included by commit e64d2de52.
- From: David Miller <davem at davemloft dot net>
- To: tuliom at linux dot vnet dot ibm dot com
- Cc: libc-alpha at sourceware dot org, ryan dot arnold at gmail dot com, aj at suse dot com, carlos at systemhalted dot org
- Date: Mon, 02 Apr 2012 17:47:10 -0400 (EDT)
- Subject: Re: [PATCH] Fix a regression bug included by commit e64d2de52.
- References: <4F75A34B.201@suse.com><1333383617-16707-1-git-send-email-tuliom@linux.vnet.ibm.com>
From: Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com>
Date: Mon, 2 Apr 2012 13:20:17 -0300
> Commit e64d2de52 included a bug when converting from TCVN-5712 to UTF8.
> This fixes the bug by properly checking for the end of input strings when
> converting from TCVN-5712 to UCS4.
> I've verified that this commit passes the same make check tests that used
> to pass before e64d2de52 on x86-64.
>
> 2012-04-02 Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com>
>
> [BZ #13691]
> * iconvdata/tcvn5712-1.c (FROM_LOOP): Fix a bug when converting
> strings ended by characters between 0x0041 and 0x01b0. Also, fix a
> regression bug inserted by commit e64d2de52.
Although mentioning the GIT commit ID introducing a problem is a (very
useful and helpful) convention in other projects, I don't think there's
been any consensus to start putting GIT commit ID references in the
ChangeLog entries of glibc yet.
Anyways, I'd like to get this regression fixed promptly so if folks
don't mind I'm going to commit this fix with the ChangeLog tidied up.
Any objections?