This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: State of libc-locale? (and scope of committers)


  Hi!

On Wed, Apr 04, 2012 at 10:46:10AM +0200, Andreas Jaeger wrote:
> Looking at the libc-locale archives and the many open bugs regarding 
> locales: Is anybody still taking care of the locales?

  In the past, I was doing some triage but it did not seem appropriate
for me to commit any of the patches I approved of - it seems that now,
the situation is different and this could be ok.

  But I'm not even sure in general if the situation is now that as
a committer, I can commit (non-controversial) patches of others that
I review (or commit my patches acked by other committers), or per

	http://sourceware.org/glibc/wiki/MAINTAINERS

if Roland or Ulrich still need to bless all changes committed to master
first. Based on some discussions, it seems I'm not the only one confused
about this. What should we do about things like trivial bugfixes stashed
in Bugzilla?


  Sometimes, a locale change can be rather political issue and not
so easy decision:

	http://sourceware.org/bugzilla/show_bug.cgi?id=1015

  I wonder how to deal with these cases (but also more trivial locale
changes). I propose that given shortage of general locale experts, we
should take a liberal view and it should be up to *whichever committer
takes a look at the bug* to

  * verify requirements (confirmation of practice in well known media
    / government sources)
  * review the patch
  * moderate the discussion (and try to ask original author's opinion
    if this is modification of existing locale; often, this is
    impossible, though)
  * determine the consensus if he deems the bug is ready
  * commit the patch and close the bug

What do people think about such a practice?

  P.S.: In case of bug 1015, given the IANA assignment, my resolution
would be asking in the bug if anyone still has issue with the change
(since it's been long time since the discussion started), briefly
reviewing the patch and after 7 days, adding be_BY@tarask to master.

-- 
				Petr "Pasky" Baudis
	Smart data structures and dumb code works a lot better
	than the other way around.  -- Eric S. Raymond


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]