This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] memset: fix define usage for shared libs
- From: David Miller <davem at davemloft dot net>
- To: vapier at gentoo dot org
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 04 Apr 2012 21:32:11 -0400 (EDT)
- Subject: Re: [PATCH] memset: fix define usage for shared libs
- References: <1298399284-1537-1-git-send-email-vapier@gentoo.org><1333589162-9846-1-git-send-email-vapier@gentoo.org>
From: Mike Frysinger <vapier@gentoo.org>
Date: Wed, 4 Apr 2012 21:26:02 -0400
> The proper define to check "am I in a shared lib" is "SHARED", not "PIC".
> The two new memset_chk functions incorrectly depend on "PIC".
I'm ambivalent on this one, because there are other locations
where we essentially test libc.a vs. libc.so using PIC too.