This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: DL_DEBUG_UNUSED buggy, especially with vdso


On 04/05/2012 02:23 AM, David Miller wrote:
From: David Miller<davem@davemloft.net>
Date: Wed, 04 Apr 2012 02:22:59 -0400 (EDT)

From: David Miller<davem@davemloft.net>
Date: Tue, 03 Apr 2012 23:59:32 -0400 (EDT)

2) Dealing with the PLT lazy eval issue.  We can't just pretend
    LD_BIND_NOW is set because in this test case testobj1.so also
    references a symbol 'foo' via the PLT which will be undefined

And this addresses the PLT lazy eval issue.


Any objections?

I'm extremely confident in these two fixes, and they get unused dep analysis actually working again on all platforms. Could someone please review them?

I tested on Linux/x86-64 and Linux/x86 as well and it passed the testsuite.


The two patches look fine to me, thanks!

Andreas
--
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]