This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Thursday 05 April 2012 02:29:27 Carlos O'Donell wrote: > On Wed, Apr 4, 2012 at 9:26 PM, Mike Frysinger <vapier@gentoo.org> wrote: > > The proper define to check "am I in a shared lib" is "SHARED", not "PIC". > > The two new memset_chk functions incorrectly depend on "PIC". > > > > Signed-off-by: Mike Frysinger <vapier@gentoo.org> > > > > 2011-02-22 Mike Frysinger <vapier@gentoo.org> > > > > * sysdeps/i386/i686/memset_chk.S: Change PIC to SHARED. > > * sysdeps/x86_64/memset_chk.S: Likewise. > > Please check this in. i don't recall being granted access to glibc git repo ... i'm in the sourceware.org cvs tree ... > However, please re-read Ulrich's comments. His original complaint is valid. i don't know what you mean. i pointed out that "SHARED" and "PIC" have different meanings, and this code was utilizing the wrong one. > Tell us about your users, and your use case, and why something which > *normally* works (even if it's not correct), no longer works. > > That way we can *own* your problem and in the future when writing code > we'll remember why we need to be precise about PIC vs. SHARED. in the original posting, i was omitting "we build static objects for PIE usage which implies PIC" because Ulrich specifically rejected any patches that fixed that use case. in the repost, i could have included more details since we appear to be on a sane path now. -mike
Attachment:
signature.asc
Description: This is a digitally signed message part.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |