This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Use __builtin_bswap32/64 for GCC >= 4.2


On Thu, Apr 5, 2012 at 2:06 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, Apr 5, 2012 at 2:01 PM, Roland McGrath <roland@hack.frob.com> wrote:
>> Any static inlines need to use __attribute__ ((__unused__)).
>
> __attribute__ ((__unused__)) may not work for all compilers.
> Should we use __extern_inline since it is a user visible header
> file?

__extern_inline  doesn't work with all compilers.  I checked
all user-visible glibc header files with inline functions.  They
are declared with static __inline, __extern_always_inline or
__extern_inline.  None of them use __attribute__ ((__unused__)).
If static __inline should be changed, I believe it should be done
with a separate patch.


-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]