This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Remove no longer applicable assertion.


From: "Carlos O'Donell" <carlos@systemhalted.org>
Date: Fri, 6 Apr 2012 05:17:17 -0400

> Would the following be more optimal?

Well, it's taking another step.  My changes accomodated the case where
there is no DT_REL(A) present at all, as did the existing code.

But with your change, we are assuming that a DT_REL(A) is always
present.

And if you think it's OK to assume that, then you can also turn the
first if() statement in this macro:

    if ((map)->l_info[DT_##RELOC])

into an assertion and just cons up ranges[0] unconditionally.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]