This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/3] Isolate test case execution from external environment


On Fri, 6 Apr 2012, Siddhesh Poyarekar wrote:

> +ifndef test-lib-paths
> +ifeq ($(CC),gcc)

This conditional is never appropriate.  The compiler is always some form 
of GCC - possibly a cross compiler, possibly something including options 
such as "gcc -mx32".  You should use this logic, with $(CC) (probably 
together with $(CFLAGS)), unconditionally.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]