This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Add bits/byteswap-16.h and use GCC builtin 32/64-bit bswap
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 6 Apr 2012 12:57:44 -0700 (PDT)
- Subject: Re: PATCH: Add bits/byteswap-16.h and use GCC builtin 32/64-bit bswap
- References: <20120406194013.GA4689@intel.com>
You ignored my feedback about "16bit" in comments.
> +/* Macros to swap the order of bytes in 16bit integer values.
^
> + Copyright (C) 2012 Free Software Foundation, Inc.
^ excess space here
This is too much churn at once. First do a change that just splits out
byteswap-16.h and nothing else. Then we can look at the rest.
Thanks,
Roland