This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Add bits/byteswap-16.h and use GCC builtin 32/64-bit bswap
On Fri, Apr 6, 2012 at 2:02 PM, Roland McGrath <roland@hack.frob.com> wrote:
>> The updated patch is at
>>
>> http://sourceware.org/git/?p=glibc.git;a=patch;h=8b89aff0004899a676c3eff0b7ab82519fc8d99a
>
> You should probably post patches as well as publishing them in git.
> The private git branches might not live forever, but the list archive will.
>
> This is still doing more than simply splitting out bswap_16,
> like dropping the i386 file completely though it has i386-specific
> code for bswap_32.
>
> Please post a patch that really affects only bswap_16.
>
The whole idea of adding byteswap-16.h is to prepare for
__builtin_bswap32 and __builtin_bswap64. If we want
to use __builtin_bswap32 and __builtin_bswap64, it makes
no senses to update those bits/byteswap.h files which will be
removed by __builtin_bswap32 and __builtin_bswap64 anyway.
If we don't want to use __builtin_bswap32 and __builtin_bswap64,
let's make a decision now before I waste my time on it.
Thanks.
--
H.J.