This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Add bits/byteswap-16.h and use GCC builtin 32/64-bit bswap


> The whole idea of adding byteswap-16.h is to prepare for
> __builtin_bswap32 and __builtin_bswap64.   If we want
> to use __builtin_bswap32 and __builtin_bswap64, it makes
> no senses to update those bits/byteswap.h files which will be
> removed by __builtin_bswap32 and __builtin_bswap64 anyway.
> If we don't want to use __builtin_bswap32 and __builtin_bswap64,
> let's make a decision now before I waste my time on it.

It always makes sense to separate separable changes.
It's very likely that the end-state you want will be just fine.
But it's hard to review such a giant patch all at once.
If there turn out to be unanticipated problems, then we can
see which of the individual changes has the problem.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]