This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Add bits/byteswap-16.h and use GCC builtin 32/64-bit bswap


On Fri, Apr 6, 2012 at 2:40 PM, Roland McGrath <roland@hack.frob.com> wrote:
>> My end goal is to add byteswap-16.h and remove
>> arch-dependent byteswap.h. ?I assume the so called
>> "giant" patch is due to removing arch-dependent byteswap.h
>> files. ?Why can't removing arch-dependent byteswap.h
>> be reviewed now?
>
> It can be reviewed soon. ?It just can't all be reviewed as one big patch,
> or all go in as one big commit. ?If you'd spent as much time slicing things
> up into small pieces as I asked as you've already spent arguing about it,
> then more than half your work would have been committed by now.

To do what you suggested, for each arch-dependent bits/byteswap.h, I
need to remove __bswap_16 and add "#include <bits/byteswap-16.h>",
followed by a "giant" patch to remove arch-dependent bits/byteswap.h
files I just changed.

We can review the "giant" patch now when byteswap-16.h is added
or later when the arch-dependent bits/byteswap.h files are removed.

Since there will be a "giant" patch anyway, why not now?

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]