This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Add bits/byteswap-16.h and use GCC builtin 32/64-bit bswap


On Fri, Apr 6, 2012 at 6:00 PM, Roland McGrath <roland@hack.frob.com> wrote:
> The changes are logically separate. ?"Giant" is not (just) about the number
> of lines in a patch. ?It's about the conflation of multiple issues that a
> reviewer then has to tease apart again to understand the change.

I agree. Having to think about multiple issues while reviewing a patch
makes the review more difficult. The term "giant" is perhaps not the
best name for this kind of problem ;-)

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]