This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] PowerPC - logb/ilogb optimization for POWER7
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- Cc: "GNU C. Library" <libc-alpha at sourceware dot org>
- Date: Tue, 10 Apr 2012 16:03:22 +0000 (UTC)
- Subject: Re: [PATCH] PowerPC - logb/ilogb optimization for POWER7
- References: <4F84557E.2040306@linux.vnet.ibm.com>
On Tue, 10 Apr 2012, Adhemerval Zanella wrote:
> +#if defined TEST_FLOAT
> + TEST_f_i (ilogb, 1.701412e+38, 127);
> +#endif
This appears to be correct for all floating-point formats, so should not
have the #if conditional at all.
> +#if defined TEST_DOUBLE
> + TEST_f_i (ilogb, 8.988466e+307, 1023);
> +#endif
And this should be #ifndef TEST_FLOAT (it's applicable to all long double
formats as well as double).
Do these optimized versions raise exceptions as specified by current
POSIX? If not, then when bug 6794 is fixed (and associated testcases
added / existing tests made stricter about what exceptions are raised)
they will need to be fixed as well....
--
Joseph S. Myers
joseph@codesourcery.com