This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PowerPC - logb/ilogb optimization for POWER7


On 04/10/2012 01:03 PM, Joseph S. Myers wrote:
> On Tue, 10 Apr 2012, Adhemerval Zanella wrote:
>
>> +#if defined TEST_FLOAT
>> +  TEST_f_i (ilogb, 1.701412e+38, 127);
>> +#endif
> This appears to be correct for all floating-point formats, so should not 
> have the #if conditional at all.
>
>> +#if defined TEST_DOUBLE
>> +  TEST_f_i (ilogb, 8.988466e+307, 1023);
>> +#endif
> And this should be #ifndef TEST_FLOAT (it's applicable to all long double 
> formats as well as double).
>
> Do these optimized versions raise exceptions as specified by current 
> POSIX?  If not, then when bug 6794 is fixed (and associated testcases 
> added / existing tests made stricter about what exceptions are raised) 
> they will need to be fixed as well....
>
I'll work on bug 6794 and then resend my patch. Thanks for you input.


-- 
Adhemerval Zanella Netto
  Software Engineer
  Linux Technology Center Brazil
  Toolchain / GLIBC on Power Architecture
  azanella@linux.vnet.ibm.com / azanella@br.ibm.com
  +55 61 8642-9890


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]