This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/4 v2] [SH/SH4]: Fix return value which ROUND is no validrounding mode


Hi,

2012/4/11 Thomas Schwinge <thomas@codesourcery.com>:
> Hi!
>
> On Wed, 11 Apr 2012 15:05:32 +0900, Nobuhiro Iwamatsu <iwamatsu@nigauri.org> wrote:
>> 2012/4/10 Carlos O'Donell <carlos@systemhalted.org>:
>> > On Wed, Apr 4, 2012 at 9:37 PM, Nobuhiro Iwamatsu <iwamatsu@nigauri.org> wrote:
>> >> - ? Copyright (C) 1998, 2000, 2005 Free Software Foundation, Inc.
>> >> + ? Copyright (C) 1998, 2000, 2005, 2012 Free Software Foundation, Inc.
>> >
>> > Merge years into "1998-2012"
>
>> >> @@ -27,7 +27,7 @@ fesetround (int round)
>> >>
>> >> ? if ((round & ~0x3) != 0)
>> >> ? ? /* ROUND is no valid rounding mode. ?*/
>> >> - ? ?return 0;
>> >> + ? ?return 1;
>> >> [...]
>
>> > Kaz or Thomas should review these.
>>
>> This already commit by f402708f8a593280992bdaf037f57c6a16c233cc.
>
> Yes, Kaz already had reviewed and committed these patches.
>
>> If you can , please fix copyright year.
>
> This is not urgent; just do it in the way Carlos suggested for any
> further patches.
>

I see, thanks.

Nobuhiro


-- 
Nobuhiro Iwamatsu
?? iwamatsu at {nigauri.org / debian.org}
?? GPG ID: 40AD1FA6


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]