This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] cy_GB/en_GB: set am/pm in times
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: libc-alpha at sourceware dot org, Keld dot Simonsen at dkuug dot dk, pablo at mandrakesoft dot com, Petr Baudis <pasky at suse dot cz>
- Date: Thu, 12 Apr 2012 01:03:41 -0400
- Subject: Re: [PATCH] cy_GB/en_GB: set am/pm in times
- References: <1334203640-4338-1-git-send-email-vapier@gentoo.org>
On Thu, Apr 12, 2012 at 12:07 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> The British people apparently use am/pm in time, so make it available to
> them. ?While we're here, sync the date_fmt field from en_GB to cy_GB.
>
> Fedora has been carrying this for the better part of a decade, and Debian
> has had it, and now that I've gotten a request from some British people
> to add it to Gentoo, I'd rather get it merged into mainline.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> 2012-04-12 ?Mike Frysinger ?<vapier@gentoo.org>
>
> ? ? ? ?[BZ #3768]
> ? ? ? ?* locales/en_GB: Set am_pm and t_fmt_ampm fields.
Mike,
While I trust the distros, a bit of due-diligence on my part has
result in some confusion on my part.
I've CC'd the authors of the locales for comment. I'm also including
Petr Baudis whom I consider our locale expert.
For reference:
http://sourceware.org/glibc/wiki/Locales
> ? ? ? ?* locales/cy_GB: Likewise. ?Also copy date_fmt from en_GB.
> ---
> ?localedata/locales/cy_GB | ? ?7 +++++--
> ?localedata/locales/en_GB | ? ?4 ++--
> ?2 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/localedata/locales/cy_GB b/localedata/locales/cy_GB
> index 9615c3f..0415e78 100644
> --- a/localedata/locales/cy_GB
> +++ b/localedata/locales/cy_GB
> @@ -248,8 +248,11 @@ mon ? ? ? ? "<U0049><U006F><U006E><U0061><U0077><U0072>";/
> ?d_t_fmt ? ? "<U0044><U0079><U0064><U0064><U0020><U0025><U0041><U0020><U0025><U0064><U0020><U006d><U0069><U0073><U0020><U0025><U0042><U0020><U0025><U0059><U0020><U0025><U0054><U0020><U0025><U005A>"
> ?d_fmt ? ? ? "<U0025><U0064><U002E><U0025><U006D><U002E><U0025><U0079>"
> ?t_fmt ? ? ? "<U0025><U0054>"
> -am_pm ? ? ? "";""
> -t_fmt_ampm ?""
> +am_pm ? ? ? "<U0041><U004D>";"<U0050><U004D>"
> +t_fmt_ampm ?"<U0025><U006C><U003A><U0025><U004D><U003A><U0025><U0053><U0020><U0025><U0050><U0020><U0025><U005A>"
> +date_fmt ? ?"<U0025><U0061><U0020><U0025><U0062><U0020><U0025><U0065>/
> +<U0020><U0025><U0048><U003A><U0025><U004D><U003A><U0025><U0053><U0020>/
> +<U0025><U005A><U0020><U0025><U0059>"
"AM";"PM"
"%l:%M:%S %P %Z"
"%a %b %e/
+ %H:%M:%S /
+%Z %Y"
The problem I see here is that both the UK Parliament and the UK
Government website use `%A %e %B' (Wednesday 14 Apil) and never `%a %b
%e' (Wed Apr 14). Even `The Sun' uses `%a %e %b', which is just a
shortening of `%A %e %B'. In addition I see uses of `am' and 'pm'
lowercase, and `%H.%M' not `%H:%M', on government documents (I'm
willing to ignore these as government quirks).
How was this format decided?
> ?END LC_TIME
>
> ?LC_MESSAGES
> diff --git a/localedata/locales/en_GB b/localedata/locales/en_GB
> index 6a81d6d..32a4e6c 100644
> --- a/localedata/locales/en_GB
> +++ b/localedata/locales/en_GB
> @@ -116,8 +116,8 @@ mon ? ? ? ? "<U004A><U0061><U006E><U0075><U0061><U0072><U0079>";/
> ?d_t_fmt ? ? "<U0025><U0061><U0020><U0025><U0064><U0020><U0025><U0062><U0020><U0025><U0059><U0020><U0025><U0054><U0020><U0025><U005A>"
> ?d_fmt ? ? ? "<U0025><U0064><U002F><U0025><U006D><U002F><U0025><U0079>"
> ?t_fmt ? ? ? "<U0025><U0054>"
> -am_pm ? ? ? "";""
> -t_fmt_ampm ?""
> +am_pm ? ? ? "<U0041><U004D>";"<U0050><U004D>"
> +t_fmt_ampm ?"<U0025><U006C><U003A><U0025><U004D><U003A><U0025><U0053><U0020><U0025><U0050><U0020><U0025><U005A>"
"AM";"PM"
"%l:%M:%S %P %Z"
Same comments as above apply here.
> ?date_fmt ? ? ? "<U0025><U0061><U0020><U0025><U0062><U0020><U0025><U0065>/
> ?<U0020><U0025><U0048><U003A><U0025><U004D><U003A><U0025><U0053><U0020>/
> ?<U0025><U005A><U0020><U0025><U0059>"
> --
> 1.7.8.5
If possible I would like to get some comments from the locale authors and Petr.
Cheers,
Carlos.