This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/4] [Powerpc] tune/optimize memmove/wordcopy. Populatepower7 wordcopy.c files.


On Thu, Apr 12, 2012 at 8:26 AM, Will Schmidt <willschm@us.ibm.com> wrote:
> "Ryan S. Arnold" <ryan.arnold@gmail.com> wrote on 04/11/2012 02:40:51 PM:
>
>> "Ryan S. Arnold" <ryan.arnold@gmail.com>
>> Subject
>>
>> Re: [PATCH 3/4] [Powerpc] tune/optimize memmove/wordcopy. Populate
>> power7 wordcopy.c files.
>
>
>>
>> On Tue, Apr 3, 2012 at 1:08 PM, Will Schmidt
>> <will_schmidt@vnet.ibm.com> wrote:
>> > [Powerpc] tune/optimize memmove/wordcopy. ÂPopulate power7 wordcopy.c
>> > files.
>> >
>> > Populate the power7 sysdep directories with versions of the wordcopy.c
>> > files.
>> >
>> > 2012-04-03 ÂWill Schmidt <will_schmidt@vnet.ibm.com>
>> >
>> > Â Â Â Â* sysdeps/powerpc/powerpc64/power7/wordcopy.c: New file. (Copied
>> > from
>> > Â Â Â Âsysdeps/powerpc/powerpc64/power6/wordcopy.c)
>> > Â Â Â Â* sysdeps/powerpc/powerpc32/power7/wordcopy.c: New file. (Copied
>> > from
>> > Â Â Â Âsysdeps/powerpc/powerpc32/power6/wordcopy.c)
>> > Â Â Â Â* sysdeps/powerpc/memmove.c: New file. Â(Copied from
>> string/memmove.c).
>>
>> Seeing as how, with this patch-set, the power7 versions are just a
>> copy of the power6 versions of the files, wouldn't it be better to do
>> the following in order to avoid redundant code?
>>
>> sysdeps/powerpc/powerpc32/power7/wordcopy.c:
>> #include "../power6/wordcopy.c"
>
> Give me a clear indication of whether you will check in parts 1,2,4 ;
>
> I'll follow up with power7 changes (either distinct variations or
> #include-power6-versions)
> once I've determined whether any of the power7 changes prove worthy.

If there are no objections from the others, I'm agreeable to parts
1,2, and 4 and can push them.

Looking at the power7/Implies files (and a power7 build), I see that
it already includes power6/ so we're picking up the power6/wordcopy.c
anyway.

The #include of the power6 version isn't necessary.

So if/when you have some distinct variations from the
power6/wordcopy.c, then add a power7 version.

Ryan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]