This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PowerPC - Add a faster way to read the Time Base register


On Wed, Apr 11, 2012 at 2:39 PM, Roland McGrath <roland@hack.frob.com> wrote:
>> + Â You should have received a copy of the GNU Lesser General Public
>> + Â License along with the GNU C Library; if not, write to the Free
>> + Â Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
>> + Â 02111-1307 USA. Â*/
>
> This boilerplate is old. ÂUse an example from a current public header file.
> This file probably needs the "special exception" text.

Hi Roland,

I suppose this is necessary since the code in these code fragments are
static inline and a program that includes them would technically be
statically linking the code into the executable, and thus not exempt
via the linking clause of the LGPL.  I didn't find an existing special
exception template in GLIBC which fit this scenario exactly but I
found one in GCC that I adapted:

"As a special exception, you may use this file as part of a library or
executable without restriction.  Specifically, if other files use
macros or inline functions from this file, or you compile this file
and link it with other files to produce an executable, this file does
not by itself cause the resulting executable to be covered by the
Lesser GNU General Public License.  This exception does not, however,
invalidate any other reasons why the executable might be covered by
the Lesser GNU General Public License."

Thoughts?

>
>> +/* Test if __ppc_get_timebase() is compatible with the current processor and if
>> + Â it's changing between reads.
>> + Â In case of a read failure it may indicate a future Power ISA or a binutils
>> + Â change. Â*/
>
> New tests should get a copyright header too.

I see a copyright header in the new testcase...


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]