This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/3] Define libgcc soname in make scripts and not in aheader


On Thu, 12 Apr 2012 13:45:24 -0400, Carlos wrote:
> * Add some configure sanity checks to ensure runtime matches
> expectations?

I cannot think of a way to do this without adding a lot of cruft
(finding all shlib-versions, grepping, etc.). Besides, I thought the
point of dynamically loading libgcc_s.so was to have a loose dependency
on it so that even if it is absent in the target system, one can do
everything with pthreads except for async cancel. So having a configure
check for it doesn't really make sense to me. It also does not make
sense to even put out a warning during build since the build process
does not seem to need it.

What I was planning to do instead is propose putting in a check for the
correct libgcc_s in the 'make check' target:

http://sourceware.org/ml/libc-alpha/2012-04/msg00229.html

since tests may fail and raise false alarms. That patch still needs to
be reworked of course, with all of the feedback I have got so far and
going by my own argument above, failing to find libgcc_s should not be
fatal. Instead, it should only print out a warning saying that pthread
cancellation related tests may fail. In the ideal case, the tests
should get skipped but we don't have that kind of feature in our
testsuite yet. I'll resubmit that patch with changes once this change
is finalized and committed.

I have attached the patch for the shlib-versions move and
related adjustments. I have tested it with a full build. Analogous
changes need to go into the hppa and m68k ports for them to work with
this. Does this look OK?

Regards,
Siddhesh


ChangeLog:
2012-04-13  Siddhesh Poyarekar  <siddhesh@redhat.com>

	* shlib-versions: Add libgcc_s version information.
	* sysdeps/generic/libgcc_s.h: Remove.
	* sysdeps/generic/framestate.c: Include gnu/lib-names.h instead
	  of libgcc_s.h.
	* sysdeps/gnu/unwind-resume.c: Ditto.
	* scripts/test-installation.pl: Remove libgcc_s from link_libs.

nptl/ChangeLog:
2012-04-13  Siddhesh Poyarekar  <siddhesh@redhat.com>

	* sysdeps/pthread/unwind-forcedunwind.c: Include gnu/lib-names.h
	instead of libgcc_s.h.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]