This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] ld.so: Fix dlclose() removing required local scope elementsof NODELETE linkmaps


I don't know the details of this sufficiently well off hand to review the
logic of the change right now.  So here's just some style points.

> +#define mark_used(dmap) \

We usually use inline functions (sometimes nested ones) rather than macros
when we can.  This looks like a case where a nested inline would work fine.

> +	      mark_used(*lp);

Space before paren (other instances below).


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]