This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv3 0/4] Tune and tweak memmove/wordcopy code for Powerpc
- From: "Ryan S. Arnold" <ryan dot arnold at gmail dot com>
- To: libc-alpha at sourceware dot org
- Cc: Will Schmidt <will_schmidt at vnet dot ibm dot com>
- Date: Tue, 17 Apr 2012 09:15:27 -0500
- Subject: Re: [PATCHv3 0/4] Tune and tweak memmove/wordcopy code for Powerpc
- References: <20120403180700.5689.57731.stgit@brimstone>
On Tue, Apr 3, 2012 at 1:07 PM, Will Schmidt <will_schmidt@vnet.ibm.com> wrote:
> The following series copies, tunes and tweaks the implementation of memove
> and wordcopy functions for powerpc, with focus on power6 and power7.
>
> The "Call memcpy when appropriate" optimization (4/4) could apply to other
> architectures generically; but I can not make any claims to how
> much improvement (if any) it provides for those archs.
>
> Version 2 changes:
> Â- Per feedback, Added helper macros to the power6 versions of wordcopy.c
> before populating the power7 subdir with copies of those files.
> Â- Eliminated the now redundant switch() statement calling the macro, in turn
> eliminating the need for v1 patch 'convert switch to if-then-else'.
> Â- Dropped the v1 patch 'preload srcp values' patch (for now). ÂIt was not
> providing measurable improvement.
>
> Version 3 changes, per feedback received from v2:
> Â- Collapsed copyright date ranges.
> Â- Corrected spacing around parens ().
> Â- Removed errant semicolons from macros.
> Â- Converted ">" to ">=" for overlap check.
>
> Will Schmidt (4):
> Â Â Â[Powerpc] tune/optimize memmove/wordcopy. Add helper macro to call MERGE.
> Â Â Â[Powerpc] tume/optimize memmove/wordcopy. Remove switch statement.
> Â Â Â[Powerpc] tune/optimize memmove/wordcopy. Populate power7 files.
> Â Â Â[Powerpc] tune/optimize memmove/wordcopy. Call memcpy when appropriate.
Per discussions in the [PATCH 3/4] email, I intend to apply patches 1,
2, and 4 in their entirety and the part of patch 3 that makes the
local copy of memmove.c in preparation for a power specific change.
The copy of wordcopy.c to the power7/ directory will be left out.
I have a question on commit procedure.
When a patch set is to be committed which process should be used:
1) Apply all patches locally and commit as a single commit, merging
the ChangeLogs.
or
2) Apply each patch and commit individually.
Ryan