This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCHv3 0/4] Tune and tweak memmove/wordcopy code for Powerpc


On Wed, Apr 18, 2012 at 6:27 PM, David Miller <davem@davemloft.net> wrote:
> From: "Ryan S. Arnold" <ryan.arnold@gmail.com>
> Date: Wed, 18 Apr 2012 16:56:41 -0500
>
>> I pushed the patches to upstream master as three separate commits.
>>
>> Patch 1 and 2 were individually committed as-is.
>>
>> Patch 3 had the power7 changes removed (as unnecessary) leaving the
>> memmove copy for powerpc that was merged with the __builtin_memcpy
>> call in Patch 4.
>
>
> I just noticed that in your patch #3 the code uses __builtin_memcpy
> but the changelog and commit message mention __builtin_memcopy :-)

I noticed this after-the-fact as well.. *sigh*  Thankfully
__builtin_memcpy is what's in the source uses and is correct.  I
inherited that typo from Will's Patch 4 ChangeLog.

Ryan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]