This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch][trivial] Cleanup: delete unused TLS_{GET,SET}_FS


On Thursday, April 12, 2012 19:20:23 Paul Pluzhnikov wrote:
> Greetings,
> 
> I can't find any current or past use of TLS_GET_FS and TLS_SET_FS, and
> the patch below deletes them.
> 
> Tested by building on Linux/x86_64.
> Ok for trunk?
> 
> Thanks,
> --
> Paul Pluzhnikov
> 
> 2012-04-12  Paul Pluzhnikov  <ppluzhnikov@google.com>
> 
> 	* nptl/sysdeps/x86_64/tls.h (TLS_GET_FS): Delete.
> 	(TLS_SET_FS): Likewise.

nptl has its own ChangeLog file, this needs to go into nptl/ChangeLog and 
thus the file reference is: sysdeps/x86_64/tls.h

With this change - and after updating the copyright years, the patch is ok,

Andreas
> 
> 
> diff --git a/nptl/sysdeps/x86_64/tls.h b/nptl/sysdeps/x86_64/tls.h
> index f644f0d..17c2286 100644
> --- a/nptl/sysdeps/x86_64/tls.h
> +++ b/nptl/sysdeps/x86_64/tls.h
> @@ -133,13 +133,6 @@ typedef struct
>    (((tcbhead_t *) (descr))->dtv)
> 
> 
> -/* Macros to load from and store into segment registers.  */
> -# define TLS_GET_FS() \
> -  ({ int __seg; __asm ("movl %%fs, %0" : "=q" (__seg)); __seg; })
> -# define TLS_SET_FS(val) \
> -  __asm ("movl %0, %%fs" :: "q" (val))
> -
> -
>  /* Code to initially initialize the thread pointer.  This might need
>     special attention since 'errno' is not yet available and if the
>     operation can cause a failure 'errno' must not be touched.

-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]