This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] nscd does not account for 'multi on' in /etc/host.confwhen ai-resolving hosts


On Fri, 13 Apr 2012 18:46:54 +0200, Petr wrote:
> http://sourceware.org/bugzilla/show_bug.cgi?id=11928
> (Waiting for review for almost two years now.)
> 
> When nscd is handling getaddrinfo() resolution requests, it fails
> to properly initialize its resolver options state and ignores
> /etc/host.conf.
> 
> This patch makes sure _res_hconf is initialized before resolving is
> being done.  However, this would not be enough since nscd has its own
> _res_hconf due to nscd/res_hconf.c; _res_hconf_init() would work on
> different _res_hconf instance than the NSS routines. We just need to
> make sure nscd and glibc share the same _res_hconf instance - this
> should not be a problem since users should run matching versions of
> glibc and nscd anyway.
> 
> 
> 2010-08-19  Petr Baudis <pasky@suse.cz>
> 
> 	* nscd/aicache.c (addhstaiX): Make sure _res_hconf has been
> 	initialized.
> 	* resolv/res_hconf.c (_res_hconf): Do not redefine outside
> 	of libc.

The patch makes sense. Please update copyright years in res_hconf.c and
merge them in aicache.c. Also, your ChangeLog entry is missing the bz
number.

Regards,
Siddhesh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]