This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Enable check-abi by default (was: Re: stackable abilist files)


On 04/21/2012 11:07 AM, Joseph S. Myers wrote:
> I think check-abi should be part of the default "make check", and should
> fail if no baselines are found in sysdeps (the expectation being that each
> architecture's maintainers should add baselines if not already present ...
> it appears the present baselines are missing sparc).

That's not the first time in the last few days I saw this suggestion,
so what about the following patch to change the default to always have
check-abi run as part of make check? If you don't want it, you can
configure with --disable-check-abi...

Tested on Linux/x86-64

Ok to commit?

Andreas

2012-04-21  Andreas Jaeger  <aj@suse.de>

	* configure.in (check-abi): Change default to always run check-abi
	as part of make check.
	* configure: Regenerated.

diff --git a/configure.in b/configure.in
index d8c55b1..f895d56 100644
--- a/configure.in
+++ b/configure.in
@@ -106,11 +106,11 @@ AC_ARG_ENABLE([sanity-checks],
 
 AC_SUBST(enable_check_abi)
 AC_ARG_ENABLE([check-abi],
-	      AC_HELP_STRING([--enable-check-abi],
-			     [do "make check-abi" in "make check" (no/warn/yes)
+	      AC_HELP_STRING([--disable-check-abi],
+			     [do not "make check-abi" in "make check" (no/warn/yes)
 			      @<:@default=no@:>@]),
 	      [enable_check_abi=$enableval],
-	      [enable_check_abi=no])
+	      [enable_check_abi=yes])
 
 AC_ARG_ENABLE([shared],
 	      AC_HELP_STRING([--enable-shared],

-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]