This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix make install in nss


On Sat, 21 Apr 2012, Petr Baudis wrote:

> Commit 77fb9117432a754388c52f6eb06c60a828975350 from June 2011
> hardcodes /var/db path in Makeconfig for installation of
> nss/db-Makefile.  This breaks make install to a custom prefix.
> (Something I do often during testing, so I'm slightly surprised that
> noone caught this before.)
> 
> Ok to commit? (It might be deemed obvious, but I'm not terribly
> familiar with the build system so I prefer review.)
> 
> 2012-04-21  Petr Baudis  <pasky@ucw.cz>
> 
> 	* Makeconfig: Define localstatedir depending on $(prefix),
> 	use for vardbdir.

I'd think the path should depend on $(prefix) the same way as slibdir, 
i.e. /var/db if the prefix is /usr and something under the prefix 
otherwise.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]