This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Merge sysdeps/unix/mman into sysdeps/unix
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 24 Apr 2012 11:02:05 -0400
- Subject: Re: Merge sysdeps/unix/mman into sysdeps/unix
- References: <Pine.LNX.4.64.1204210944280.23030@digraph.polyomino.org.uk>
On Sat, Apr 21, 2012 at 5:45 AM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
> There's a separate sysdeps directory sysdeps/unix/mman that exists
> only to define mmap and related syscalls. ?These can nowadays be
> considered standard for any Unix-like system and go straight in
> sysdeps/unix rather than needing an extra sysdeps directory implied by
> both sysdeps/unix/sysv/linux and sysdeps/unix/bsd/bsd4.4.
>
> I propose this patch to eliminate that separate sysdeps subdirectory,
> moving the syscalls to sysdeps/unix/syscalls.list. ?Tested x86_64,
> including making sure the compiled library binaries are identical
> before and after the patch.
>
> 2012-04-21 ?Joseph Myers ?<joseph@codesourcery.com>
>
> ? ? ? ?* sysdeps/unix/syscalls.list (madvise): Add syscall from
> ? ? ? ?sysdeps/unix/mman/syscalls.list.
> ? ? ? ?(mmap): Likewise.
> ? ? ? ?(mprotect): Likewise.
> ? ? ? ?(msync): Likewise.
> ? ? ? ?(munmap): Likewise.
> ? ? ? ?* sysdeps/unix/bsd/bsd4.4/Implies: Remove.
> ? ? ? ?* sysdeps/unix/mman/syscalls.list: Remove.
> ? ? ? ?* sysdeps/unix/sysv/linux/Implies: Don't include unix/mman.
This looks good to me.
Cheers,
Carlos.