This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 4/6] xstat: NFS: Return extended attributes
- From: David Howells <dhowells at redhat dot com>
- To: "Myklebust, Trond" <Trond dot Myklebust at netapp dot com>
- Cc: dhowells at redhat dot com, "linux-fsdevel at vger dot kernel dot org" <linux-fsdevel at vger dot kernel dot org>, "linux-nfs at vger dot kernel dot org" <linux-nfs at vger dot kernel dot org>, "linux-cifs at vger dot kernel dot org" <linux-cifs at vger dot kernel dot org>, "samba-technical at lists dot samba dot org" <samba-technical at lists dot samba dot org>, "linux-ext4 at vger dot kernel dot org" <linux-ext4 at vger dot kernel dot org>, "wine-devel at winehq dot org" <wine-devel at winehq dot org>, "kfm-devel at kde dot org" <kfm-devel at kde dot org>, "nautilus-list at gnome dot org" <nautilus-list at gnome dot org>, "linux-api at vger dot kernel dot org" <linux-api at vger dot kernel dot org>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Date: Thu, 26 Apr 2012 14:52:40 +0100
- Subject: Re: [PATCH 4/6] xstat: NFS: Return extended attributes
- References: <1334846149.21419.22.camel@lade.trondhjem.org> <20120419140558.17272.74360.stgit@warthog.procyon.org.uk> <20120419140653.17272.95035.stgit@warthog.procyon.org.uk>
Myklebust, Trond <Trond.Myklebust@netapp.com> wrote:
> Hmm... As far as I can see you are still doing an nfs_revalidate_inode()
> in the non-forced case. That will cause expired attributes to be
> retrieved from the server.
Revalidation is only done when you force it or explicitly ask for a basic stat
or the data version number:
- if (need_atime)
- err = __nfs_revalidate_inode(NFS_SERVER(inode), inode);
- else
- err = nfs_revalidate_inode(NFS_SERVER(inode), inode);
- if (!err) {
- generic_fillattr(inode, stat);
- stat->ino = nfs_compat_user_ino64(NFS_FILEID(inode));
+ if (force || stat->request_mask & (XSTAT_BASIC_STATS | XSTAT_VERSION)) {
+ if (force || need_atime)
+ err = __nfs_revalidate_inode(NFS_SERVER(inode), inode);
+ else
+ err = nfs_revalidate_inode(NFS_SERVER(inode), inode);
+ if (err)
+ goto out;
Unfortunately, I think I have to revalidate if any of XSTAT_BASIC_STATS are
requested to maintain compatibility with stat() so that stat() can be done
with xstat(). On the other hand, stat() could be done by userspace with
xstat() and AT_FORCE_ATTR_SYNC, I suppose.
David