This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Always run check-abi as part of testsuite


The appended patch always runs check-abi as part of the
testsuite. Tested on Linux/x86-64.

The consensus in the last round was that the configure option should get
removed, so this is done by the following patch.

Ok to commit?

Andreas

2012-04-26  Andreas Jaeger  <aj@suse.de>

	* Makerules (tests): Remove enable-check-abi protection.
	(check-abi-warn): Remove.
	(check-abi-%): Remove check-abi-warn usage.

	* configure.in: Remove check-abi configure option.
	* configure: Regenerated.
	* config.make.in (enable-check-abi): Remove.

Remove the configure options for running of check-abi and always
run it as part of the testsuite
---
 Makerules      |    7 +------
 config.make.in |    1 -
 configure.in   |    8 --------
 3 files changed, 1 insertion(+), 15 deletions(-)

diff --git a/Makerules b/Makerules
index 18aeb9e..11d06bc 100644
--- a/Makerules
+++ b/Makerules
@@ -1167,11 +1167,8 @@ define check-abi
 	$(AWK) -f $< -v 'config=$(check-abi-config)' \
 	       $(patsubst %,-v 'lastversion=%',$($*-abi-frozen)) \
 	       $(filter %.abilist,$^) \
-	| { diff -p -U 0 - $(filter %.symlist,$^) $(check-abi-warn) ; }
+	| { diff -p -U 0 - $(filter %.symlist,$^) ; }
 endef
-ifeq ($(enable-check-abi),warn)
-check-abi-warn = || echo '*** WARNING: $*.so failed ABI check'
-endif
 
 ifeq ($(firstword $(sysd-sorted-done) f)$(firstword $(generating) f),tf)
 config-tls := thread
@@ -1220,12 +1217,10 @@ common-generated += libc.symlist
 endif
 
 ifeq ($(build-shared),yes)
-ifneq ($(enable-check-abi),no)
 ifdef subdir
 tests: check-abi
 endif
 endif
-endif
 
 endif
 
diff --git a/config.make.in b/config.make.in
index 9aff468..1f4185b 100644
--- a/config.make.in
+++ b/config.make.in
@@ -53,7 +53,6 @@ with-fp = @with_fp@
 old-glibc-headers = @old_glibc_headers@
 unwind-find-fde = @libc_cv_gcc_unwind_find_fde@
 have-cpp-asm-debuginfo = @libc_cv_cpp_asm_debuginfo@
-enable-check-abi = @enable_check_abi@
 have-forced-unwind = @libc_cv_forced_unwind@
 have-fpie = @libc_cv_fpie@
 have-mfma4 = @libc_cv_cc_fma4@
diff --git a/configure.in b/configure.in
index 42d521f..1a8c004 100644
--- a/configure.in
+++ b/configure.in
@@ -104,14 +104,6 @@ AC_ARG_ENABLE([sanity-checks],
 	      [enable_sanity=$enableval],
 	      [enable_sanity=yes])
 
-AC_SUBST(enable_check_abi)
-AC_ARG_ENABLE([check-abi],
-	      AC_HELP_STRING([--enable-check-abi],
-			     [do "make check-abi" in "make check" (no/warn/yes)
-			      @<:@default=no@:>@]),
-	      [enable_check_abi=$enableval],
-	      [enable_check_abi=no])
-
 AC_ARG_ENABLE([shared],
 	      AC_HELP_STRING([--enable-shared],
 			     [build shared library @<:@default=yes if GNU ld@:>@]),
-- 
1.7.9.2


-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 NÃrnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix ImendÃrffer,HRB16746 (AG NÃrnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]