This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Move abilist files into sysdep dirs.


From: Andreas Schwab <schwab@linux-m68k.org>
Date: Fri, 27 Apr 2012 09:49:40 +0200

> David Miller <davem@davemloft.net> writes:
> 
>> diff --git a/Makerules b/Makerules
>> index 18aeb9e..f4ce4a6 100644
>> --- a/Makerules
>> +++ b/Makerules
>> @@ -1156,51 +1156,33 @@ ifeq ($(versioning),yes)
>>  	$(OBJDUMP) --dynamic-syms $< > $@T
>>  	mv -f $@T $@
>>  
>> -check-abi-%: $(..)scripts/extract-abilist.awk $(common-objpfx)config.make \
>> -	     $(..)abilist/%.abilist $(objpfx)%.symlist
>> +DATA_DIR := $(firstword $(wildcard $(sysdirs:=/data)))
> 
> Please spell it in lower case and with a dash.  It is not an overridable
> environment variable.

Ok, will fix that.

Anyone have any other objections or can I commit this with the
s/DATA_DIR/data-dir/ fix?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]