This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Move abilist files into sysdep dirs.


From: Roland McGrath <roland@hack.frob.com>
Date: Fri, 27 Apr 2012 10:59:29 -0700 (PDT)

>> Also, doesn't this vpath scheme make "make" work harder?  I'd like
>> this to be efficient if possible.
> 
> It's probably not significant.  It only means that it will look for
> foo.abilist, not find it, then look in the list of vpath patterns to see
> it matches %.abilist, and then look for the file.  So it's not like
> adding more implicit rules, which affects every implicit rule lookup.
> This adds a little bit of pattern-matching to checks for unfound files,
> but there aren't a lot of vpath patterns to match.  It only adds extra
> directory lookups for the *.abilist files themselves, of which there are
> only a handful.  (And with make's directory caching, that won't even
> really add any stat calls.  Actually, it will add extra opendir/readdir
> calls if you make them data/ subdirectories and none if you don't.)

Ok, thanks for the explanation.

Perhaps it's better without the data/ directory.

Joseph what do you think?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]