This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] Fix attributes for fortify functions


On Tue, Apr 24, 2012 at 01:04:57PM -0700, Roland McGrath wrote:
> > 2012-04-22  Marek Polacek  <polacek@redhat.com>
> > 
> > 	* misc/sys/cdefs.h: Define __fortify_function macro.  Don't
> > 	contain __attribute__ ((__artificial__)) in __extern_always_inline.
> > 	Define __attribute_artificial__.
> 
> Proper format:
> 
> 	* misc/sys/cdefs.h (__attribute_artificial__): New macro.
> 	(__fortify_function): New macro.
> 	(__extern_always_inline): Don't use __attribute__ ((__artificial__)).

Ok, thanks.  Will post another version of the patch shortly.

> > +/* This tells the debugger to not step through the inlined instructions.  */
> 
> I'm not aware of any such debugger feature.  The import effect of the
> attribute for _FORTIFY_SOURCE functions is that it tells the compiler to
> associate error messages with the source location of the call site rather
> than with the source location inside the function.

Ok, I'll use your words ;).

	Marek


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]