This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH,HURD] hurd: compliance fixes for getgroups
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Pino Toscano <toscano dot pino at tiscali dot it>
- Cc: libc-alpha at sourceware dot org, bug-hurd at gnu dot org
- Date: Fri, 27 Apr 2012 14:54:02 -0700 (PDT)
- Subject: Re: [PATCH,HURD] hurd: compliance fixes for getgroups
- References: <201204271243.52809.toscano.pino@tiscali.it>
> 2012-04-27 Pino Toscano <toscano.pino@tiscali.it>
>
> * sysdeps/mach/hurd/getgroups.c (__getgroups): Return -1 and set EINVAL
> for negative `n' or less than `ngids'.
The norm is to use all caps and no quotes to mention local variable
names. You can also drop the (function) when it's the only function
in the file of the same name.
The change itself is fine by me. Since I see you already have
copyright paperwork and you're doing more than just the one change,
would you like to get set up to commit yourself?
Thanks,
Roland