This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix missing vm86 symbol
> case $weak in
> + *@@*) ;;
Please add a comment here.
> # Emit a compilation rule for this syscall.
> case $weak in
> + *@@*)
> + echo "\
> +\$(foreach p,\$(sysd-rules-targets),\
> +\$(foreach o,\$(object-suffixes),\$(objpfx)\$(patsubst %,\$p,$file)\$o)): \\"
> + ;;
Do this in a way that doesn't repeat the emitting code in two cases.
Probably the right thing to do is have a single case at the top that
determines the situation we're handling (i.e. whether $weak contains
nothing but versioned names with non-default versions), and then have
the rest just test a variable. Doing that carefully would also fix
what looks like another hole but just doesn't happen to be biting any
actual cases: a list of multiple weak names, some with @ and some without.
Thanks,
Roland