This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv3] BZ#13750: Do not build manual in the source directory
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: Andreas Jaeger <aj at suse dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 2 May 2012 16:49:54 -0400
- Subject: Re: [PATCHv3] BZ#13750: Do not build manual in the source directory
- References: <hofwbq4jis.fsf@byrd.suse.de><4FA19956.3020409@suse.com>
On Wed, May 2, 2012 at 4:30 PM, Andreas Jaeger <aj@suse.com> wrote:
> On 04/26/2012 05:09 PM, Andreas Jaeger wrote:
>>
>>
>> Here's a updated patch to build the manual in the build directory and
>> not anymore in the source directory.
>>
>> Tested with make;make info pdf html;make install;make clean
>>
>> Ok to commit?
>
>
> Ping, is this ok to commit?
The patch is moving us in the right direction e.g. don't build in the
source directory.
I have only done a cursory review of the patch, but I trust that if
you built it and tested it and nothing broke that it's fine. We can
fix any cosmetic makefile bike-shedding issues at a later date.
Have you reviewed how binutils and gdb do this or are they still
building the manuals in the source tree? I remember fixing html/pdf
builds for all the toolchain projects for CodeSourcery, and I remember
ignoring this issue.
Please check this in on Friday if nobody else disagrees with me :-)
Cheers,
Carlos.