This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Do not delete make check-abi symlist files
On Wednesday, May 02, 2012 23:20:07 Roland McGrath wrote:
> That's not what you want. .PRECIOUS with actual file names prevents
> those from being deleted on interrupt, which is bad. .PRECIOUS with
> the target pattern of an implicit rule prevents files from being
> intermediate files. i.e.:
>
> .PRECIOUS: %.symlist
>
> Also, end a sentence in a comment with a period.
Here's an updated patch, ok now?
Andreas
2012-05-02 Andreas Jaeger <aj@suse.de>
* Makerules (.PRECIOUS): Add .symlist files.
(generated): Add .symlist files.
diff --git a/Makerules b/Makerules
index de87ad6..c579271 100644
--- a/Makerules
+++ b/Makerules
@@ -1158,6 +1158,12 @@ ifeq ($(versioning),yes)
vpath %.abilist $(+sysdep_dirs)
+# Make sure that symlist is not removed.
+.PRECIOUS: %.symlist
+ifdef subdir
+generated += $(foreach l,$(extra-libs),$l.symlist)
+endif
+
check-abi-%: $(common-objpfx)config.make %.abilist $(objpfx)%.symlist
$(check-abi)
check-abi-%: $(common-objpfx)config.make %.abilist $(common-
objpfx)%.symlist
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126