This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix for ldbl-128ibm acosl/asinl inaccuracies


On 05/06/2012 11:07 AM, Adhemerval Zanella wrote:
> On 05/06/2012 09:20 AM, Joseph S. Myers wrote:
>> On Wed, 2 May 2012, Adhemerval Zanella wrote:
>>
>> There's an open bug (bug 13563) for ldbl-128ibm asinl inaccuracy.  Does 
>> this patch fix that bug?
>>
>> If it fixes the bug, you should:
>>
>> * Add any relevant testcases from that bug to the testsuite.
>>
>> * Add the bug number to the ChangeLog for your patch fixing it, and to the 
>> list of fixed bugs in NEWS.
>>
>> * Close the bug as fixed.
>>
> I'll check if it fixes, but I wasn't aware of the bug report. I create the
> patch to fix make check issues after commit 'adfbc8ac9e192b6e3007f7a47852df937afa2145'
> (Fix x86 acos near 1) and 5ba3cc691c856e5c67a7d4cd4713f20a79f7ba81
> (Fix acos (-1) in round-downwards mode on x86).
>
>
My patch (31dc8730af585d8e13021484752fb20decae0661) fixes the testcase and libm already
have cover test to check for the issue, the check 'asin (0x0.ffffffffffffp0L)' was the 
test that triggered the issue for me. I believe what need to be done is add the bug
number in the ChangeLog  and in the NEWS.

I'll update the bug report with these informations.


-- 
Adhemerval Zanella Netto
  Software Engineer
  Linux Technology Center Brazil
  Toolchain / GLIBC on Power Architecture
  azanella@linux.vnet.ibm.com / azanella@br.ibm.com
  +55 61 8642-9890


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]